Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

do not rely on undefined behaviour in bytes_test.go #38

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

do not rely on undefined behaviour in bytes_test.go #38

wants to merge 1 commit into from

Commits on Aug 26, 2020

  1. do not rely on undefined behaviour in bytes_test.go 

    8 exbi equals 2^64, therefore it cannot be stored in int64. The tests use
the fact that on x86_64 the following expressions holds true:
int64(0) - 1 == math.MaxInt64.

However, this is not true for other platforms, specifically aarch64, s390x
and ppc64le.

This commit fixes it by testing the library with 7 exbi.

Fixes labstack#37
    @ondrejbudai
    ondrejbudai committed Aug 26, 2020
    Configuration menu
    Copy the full SHA
    5c8aceb View commit details
    Browse the repository at this point in the history