Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove un-necessary locking (#1) #29

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jhlange
Copy link

@jhlange jhlange commented May 11, 2019

Remove un-necessary locking in the logging API.

Remove un-necessary locking in the logging API.
@codecov-io
Copy link

codecov-io commented May 11, 2019

Codecov Report

Merging #29 into master will not change coverage.
The diff coverage is 73.33%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #29   +/-   ##
=======================================
  Coverage   58.88%   58.88%           
=======================================
  Files           6        6           
  Lines         518      518           
=======================================
  Hits          305      305           
  Misses        210      210           
  Partials        3        3
Impacted Files Coverage Δ
log/log.go 50% <73.33%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 82ef680...5c6c1c9. Read the comment docs.

@vishr
Copy link
Member

vishr commented Jun 4, 2019

@jhlange Do we event need a lock for the entire block? I just looked at the code and to me it is only necessary while dumping the buffer to writer. Let me know your thoughts?

Here is a fix: 44f2533

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants