Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build Python 3.12 and 3.13 wheels #37

Merged
merged 3 commits into from
Aug 22, 2024

Conversation

pypae
Copy link
Contributor

@pypae pypae commented Aug 22, 2024

This PR addresses the issue mentioned in this comment.

Issue

When using hatch to install pydelatin on my M1 Mac, I got the following error (Not sure > why, it works with system pip):

[...]
ERROR: Failed building wheel for pydelatin
ERROR: Could not build wheels for pydelatin, which is required to install pyproject.toml-based projects

Installing glm and adding it to the PATH worked fine:

brew install glm 
export CPLUS_INCLUDE_PATH=$(brew --prefix glm)/include:$CPLUS_INCLUDE_PATH

Cause

I was not getting a wheel because I was using Python 3.12, for which wheels were not built with the old version of cibuildwheel.

Fix

I updated pypa/cibuildwheel.

Notes

  • I successfully built the wheels running the workflow locally using act (with the publishing part commented out):

    act -P macos-11=-self-hosted -W .github/workflows/build-wheels.yml
    

@kylebarron kylebarron mentioned this pull request Aug 22, 2024
@kylebarron kylebarron merged commit 214cf12 into kylebarron:master Aug 22, 2024
1 check passed
@kylebarron
Copy link
Owner

I think we also needed a bump to macos-latest. Wheels are building now and will hopefully publish in an ~hour

@kylebarron
Copy link
Owner

kylebarron commented Aug 22, 2024

It looks like the wheel build failed for mac: https://github.com/kylebarron/pydelatin/actions/runs/10514152518/job/29131338066

I don't have time to dig into that now, but a PR is welcome

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants