fix(kuma-cp): resources that were created on 2.7.x are missing namespace labels when synced on global #11794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lobkovilya
requested review from
jakubdyszkiewicz and
Automaat
and removed request for
a team
…ace labels when synced on global Signed-off-by: Ilya Lobkov <[email protected]>
lobkovilya
force-pushed
the
fix/set-ns-before-sync
branch
from
f8c343a
to
3403eb9
Compare
michaelbeaumont
approved these changes
Oct 17, 2024
Signed-off-by: Ilya Lobkov <[email protected]>
lahabana
reviewed
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In 2.7.x method
GetMeta().GetLabels()on Kubernetes returned a label map withk8s.kuma.io/namespaceadded dynamically. This behaviour was changed in 2.9.x by #11020, the namespace label is now supposed to be set in ComputeLabels function. But this functions is called only on Create/Update of the resources. This means policies that were created on 2.7.x won't havek8s.kuma.io/namespacelabel when synced to Global. Even though the lack of namespace labels affects only how resource looks in GUI on Global it's still worth setting it.Implementation information
Set
k8s.kuma.io/namespacelabel if not exist to the resources before syncing them to Global.Supporting documentation
Fix #XX