Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(e2e): loosen up assertion on traffic route test (backport of #11764) #11775

Closed
wants to merge 1 commit into from
Closed

fix(e2e): loosen up assertion on traffic route test (backport of #11764) #11775

wants to merge 1 commit into from

Conversation

kumahq[bot]
Copy link
Contributor

@kumahq kumahq bot commented Oct 14, 2024

Automatic cherry-pick of #11764 for branch release-2.5

Generated by action

cherry-picked commit 915de62
⚠️ ⚠️ ⚠️ Conflicts happened when cherry-picking! ⚠️ ⚠️ ⚠️

On branch release-2.5
Your branch is up to date with 'origin/release-2.5'.

You are currently cherry-picking commit 915de62b3.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   test/e2e_env/universal/trafficroute/traffic_route.go

no changes added to commit (use "git add" and/or "git commit -a")

@Automaat @kumahq
fix(e2e): loosen up assertion on traffic route test (#11764)
6c43f40 
* fix(e2e): loosen up assertion on traffic route test

Signed-off-by: Marcin Skalski <[email protected]>

---------

Signed-off-by: Marcin Skalski <[email protected]>
@kumahq kumahq bot requested a review from a team as a code owner October 14, 2024 09:01
@kumahq kumahq bot requested review from jakubdyszkiewicz and Icarus9913 and removed request for a team October 14, 2024 09:01
@Automaat
Copy link
Contributor

it does not make sense to backport it as test looked differently in the previous versions

@Automaat Automaat closed this Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakubdyszkiewicz jakubdyszkiewicz Awaiting requested review from jakubdyszkiewicz jakubdyszkiewicz is a code owner automatically assigned from kumahq/kuma-maintainers

@Icarus9913 Icarus9913 Awaiting requested review from Icarus9913 Icarus9913 is a code owner automatically assigned from kumahq/kuma-maintainers

Assignees
No one assigned
Labels
conflict release-2.5
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Automaat