Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable KV DynamicPodInterfaceNaming FG by default #3180

Merged
merged 1 commit into from
Nov 30, 2024
Merged

Enable KV DynamicPodInterfaceNaming FG by default #3180

merged 1 commit into from
Nov 30, 2024

Conversation

orelmisan
Copy link
Member

What this PR does / why we need it:
Following the graduation of KubeVirt's DynamicPodInterfaceNaming feature gate[1], enable it by default.

[1] kubevirt/kubevirt#13243

Reviewer Checklist

Reviewers are supposed to review the PR for every aspect below one by one. To check an item means the PR is either "OK" or "Not Applicable" in terms of that item. All items are supposed to be checked before merging a PR.

  • PR Message
  • Commit Messages
  • How to test
  • Unit Tests
  • Functional Tests
  • User Documentation
  • Developer Documentation
  • Upgrade Scenario
  • Uninstallation Scenario
  • Backward Compatibility
  • Troubleshooting Friendly

Jira Ticket:

Release note:

Enable KubeVirt's DynamicPodInterfaceNaming feature gate by default

@orelmisan
Enable KV DynamicPodInterfaceNaming FG by default
0848184 
Following the graduation of KubeVirt's `DynamicPodInterfaceNaming`
feature gate[1], enable it by default.

[1] kubevirt/kubevirt#13243

Signed-off-by: Orel Misan <[email protected]>
@kubevirt-bot kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Nov 26, 2024
@orelmisan
Copy link
Member Author

Lets wait for kubevirt/kubevirt#13243 to be merged first.
/hold

@kubevirt-bot kubevirt-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 26, 2024
@coveralls
Copy link
Collaborator

coveralls commented Nov 26, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 12066374356

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 71.84%
Totals Coverage Status
Change from base Build 12031091119: 0.0%
Covered Lines: 6013
Relevant Lines: 8370
💛 - Coveralls

@nunnatsa
Copy link
Collaborator

Lets wait for kubevirt/kubevirt#13243 to be merged first.

merge the PR in kubevirt is not enough. We'll need a new release of kubevirt with the required change, merged in hco.

@nunnatsa nunnatsa mentioned this pull request Nov 26, 2024
Closed
11 tasks
@EdDev
Copy link
Member

EdDev commented Nov 28, 2024

Lets wait for kubevirt/kubevirt#13243 to be merged first.

merge the PR in kubevirt is not enough. We'll need a new release of kubevirt with the required change, merged in hco.

@nunnatsa , that FG graduation is for Kubevirt v1.5 and not for the v1.4 stable branch (it will not be backported).
I do not think a new release is needed on v1.4, the GA step is administrative to ensure HCO enables a non-GA feature in v1.4 that is assured to be released as GA in v1.5.

EdDev
EdDev approved these changes Nov 28, 2024
View reviewed changes
Copy link
Member

@EdDev EdDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm assuming HCO on the main branch follows Kubevirt v1.4, on which the mentioned FG exists.
Towards Kubevirt v1.5, the FG is gone (feature is GA) so this can be removed.

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 28, 2024
@nunnatsa
Copy link
Collaborator

@orelmisan , @EdDev - what about #3182? it adds a new API to set this very same KubeVirt's feature gate.

One of these PRs must be closed.

@nunnatsa
Copy link
Collaborator

/hold

@orelmisan
Copy link
Member Author

PR #3182 was intended to be a backup to this one.
I've closed it.

@nunnatsa
Copy link
Collaborator

hco-e2e-operator-sdk-gcp lane passed
/override ci/prow/hco-e2e-kv-smoke-azure

@kubevirt-bot
Copy link
Contributor

@nunnatsa: Overrode contexts on behalf of nunnatsa: ci/prow/hco-e2e-kv-smoke-azure

In response to this:

hco-e2e-operator-sdk-gcp lane passed
/override ci/prow/hco-e2e-kv-smoke-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@nunnatsa
Copy link
Collaborator

Lets wait for kubevirt/kubevirt#13243 to be merged first. /hold

Should we still wait for it?

@orelmisan
Copy link
Member Author

Lets wait for kubevirt/kubevirt#13243 to be merged first. /hold

Should we still wait for it?

Yes.

@nunnatsa
Copy link
Collaborator

/retest

@nunnatsa nunnatsa closed this Nov 28, 2024
@nunnatsa nunnatsa reopened this Nov 28, 2024
@nunnatsa
Copy link
Collaborator

closed by mistake

/lgtm
/approve

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nunnatsa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 28, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 28, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@orelmisan
Copy link
Member Author

kubevirt/kubevirt#13243 was merged.
/unhold

@kubevirt-bot kubevirt-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 30, 2024
@orelmisan
Copy link
Member Author

/retest-required

@hco-bot
Copy link
Collaborator

hco-bot commented Nov 30, 2024

hco-e2e-consecutive-operator-sdk-upgrades-aws lane succeeded.
/override ci/prow/hco-e2e-consecutive-operator-sdk-upgrades-azure
hco-e2e-upgrade-operator-sdk-sno-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-operator-sdk-sno-azure

@kubevirt-bot
Copy link
Contributor

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-consecutive-operator-sdk-upgrades-azure, ci/prow/hco-e2e-upgrade-operator-sdk-sno-azure

In response to this:

hco-e2e-consecutive-operator-sdk-upgrades-aws lane succeeded.
/override ci/prow/hco-e2e-consecutive-operator-sdk-upgrades-azure
hco-e2e-upgrade-operator-sdk-sno-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-operator-sdk-sno-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Nov 30, 2024 •
edited
Loading

@orelmisan: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/hco-e2e-consecutive-operator-sdk-upgrades-azure 0848184 link true /test hco-e2e-consecutive-operator-sdk-upgrades-azure
ci/prow/hco-e2e-upgrade-operator-sdk-sno-azure 0848184 link false /test hco-e2e-upgrade-operator-sdk-sno-azure
ci/prow/hco-e2e-operator-sdk-azure 0848184 link true /test hco-e2e-operator-sdk-azure
ci/prow/hco-e2e-operator-sdk-aws 0848184 link true /test hco-e2e-operator-sdk-aws

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@hco-bot
Copy link
Collaborator

hco-bot commented Nov 30, 2024

hco-e2e-operator-sdk-gcp lane succeeded.
/override ci/prow/hco-e2e-operator-sdk-aws
hco-e2e-operator-sdk-gcp lane succeeded.
/override ci/prow/hco-e2e-operator-sdk-azure

@kubevirt-bot
Copy link
Contributor

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-operator-sdk-aws, ci/prow/hco-e2e-operator-sdk-azure

In response to this:

hco-e2e-operator-sdk-gcp lane succeeded.
/override ci/prow/hco-e2e-operator-sdk-aws
hco-e2e-operator-sdk-gcp lane succeeded.
/override ci/prow/hco-e2e-operator-sdk-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kubevirt-bot kubevirt-bot merged commit d42d1eb into kubevirt:main Nov 30, 2024
34 checks passed
@orelmisan orelmisan deleted the ga-dynamic-pod-interface-naming-fg branch November 30, 2024 12:39
@nunnatsa
Copy link
Collaborator

kubevirt/kubevirt#13243 was merged.

This is not enough that something was merged on kubevirt, because hvo only adopts released version.

HCO is still deploying kubevirt v1.4.0, without this change.

@orelmisan
Copy link
Member Author

Hi @nunnatsa, as @EdDev previously wrote, we want to enable this feature in 1.4 by default, due do it being GAed in 1.5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EdDev EdDev EdDev approved these changes

@machadovilaca machadovilaca Awaiting requested review from machadovilaca

@orenc1 orenc1 Awaiting requested review from orenc1

Assignees

@EdDev EdDev

@nunnatsa nunnatsa

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@orelmisan @coveralls @nunnatsa @EdDev @kubevirt-bot @hco-bot