Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Addon] Add Crossplane Azure Addon for provisioning Cloud Resources on Azure #762

Merged
merged 2 commits into from
Oct 18, 2024

Conversation

yogeshselvarajan
Copy link
Contributor

Title

[Addon] Add Crossplane-Azure Addon

Description of your changes

This PR adds the Crossplane-Azure addon to the KubeVela catalog as an experimental addon. The addon facilitates the provisioning of Azure resources like Resource Groups, Virtual Networks, and Storage Accounts via Crossplane on KubeVela.

  • It contains necessary components, including CUE files and provider configurations, as well as a detailed README.md file explaining the usage, installation, and authentication setup.
  • Additionally, examples are provided in the examples directory, showing the Azure Resource Group, Virtual Network, and Storage Account creation.

How has this code been tested?

I have copied the entire addon directory crossplane-azure, which contains the CUE files and provider files. I tested this locally by using the following command:

vela addon enable ./<the-directory-path>

After enabling the addon, I verified the resource provisioning in my Azure portal. The expected resources (Resource Group, Virtual Network, and Storage Account) were successfully created.

Checklist

I have:

  • [✔] Title of the PR starts with type (e.g. [Addon], [example], or [Doc]).
  • [✔] Updated/Added relevant documentation and examples.
  • [✔] Placed the new addon in experimental.
  • [✔] Updated the addon version in metadata.yaml.

Request for Reviewers

Dear Maintainers,

This PR introduces the Crossplane-Azure addon for provisioning Azure resources (Resource Groups, VNETs, Storage Accounts) via Crossplane in KubeVela. I kindly request that this addon (Crossplane-Azure), along with the Crossplane and Crossplane-AWS addons (currently in experimental), be promoted to public. This would enable users to manage cloud resources more efficiently across Azure and AWS using Kubevela.

In future updates, I plan to add more CUE files for Azure resources to expand its provisioning capabilities from KubeVela. I will include the proper CUE files using the Azure CRDs for Crossplane (refering Azure CRDs for Crossplane).

@anoop2811
Copy link
Contributor

Can you make sure your commits are signed?

@yogeshselvarajan
Copy link
Contributor Author

Can you make sure your commits are signed?

@anoop2811 Yes, I have followed the steps and signed the commit. I have force-pushed the commit again with signing using the following commands:

git rebase HEAD~1 --signoff
git push --force-with-lease origin crossplane-azure-addon

…and uninstallation

Signed-off-by: Yogesh Selvarajan <[email protected]>
@anoop2811 anoop2811 merged commit ad1f87d into kubevela:master Oct 18, 2024
3 checks passed
@anoop2811
Copy link
Contributor

Thank you for your contrinution @yogeshselvarajan !

@yogeshselvarajan
Copy link
Contributor Author

Thank you for your contrinution @yogeshselvarajan !

@anoop2811 Thanks for approving this addon PR. I hope this will greatly benefit KubeVela users 🌟. Could you please guide me on the procedure to promote this addon from experimental to a main addon? It has passed the e2e tests and includes a detailed README, which will be helpful for users.

Additionally, I would like to request the promotion of the Crossplane experimental addon (a necessary dependency) to verified/public status.

Please let me know the steps required for this 😊

@yogeshselvarajan
Copy link
Contributor Author

Also @anoop2811, I see that the PR has been merged, but I noticed that my new addon isn't reflecting in the KubeVela UI. I can only see the existing Crossplane and Crossplane-AWS addons (attached screenshot), with the expeiremntal addon source too enabled in the KubeVela.

Should I be updating something like an OSS bucket, or is there a need to modify the invisible tag in the addon file? Please advise on what might be missing.

Screenshot_2024-10-18-23-21-05-826_com.opera.browser.jpg

@yogeshselvarajan yogeshselvarajan deleted the crossplane-azure-addon branch October 19, 2024 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants