refactor/debugging failed cluster setup #4215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prevents issues related to empty spaces, line breaks, existing quotes etc.
monojack
requested review from
devcatalin,
topliceanurazvan and
olensmar
as code owners
WitoDelnat
approved these changes
Feb 23, 2024
|
Nice work! 💪 One nitpick is that I'd remove the "closes 4213". We'll want to get back to the users to see if their problems are solved or if the additional logging gives details into what's going on. |
olensmar
approved these changes
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screen.Recording.2024-02-22.at.10.38.25.mov
Keeps track of the most recent proxy instance so the user always has access to the debug logs even if the connection attempt failed. The PR also includes a tentative fix for when the
kubeconfigfile path and/orcontextname contain empty spaces or other characters that might break the cli command format.