Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gcp: Allow GCB service agent for kubernetes-release-test #7273

Merged

Conversation

ameukam
Copy link
Member

@ameukam ameukam commented Sep 9, 2024

Ref:

Temporary allow the Service Agent for the GCB Service from project kubernetes-release-test. This will enable artifacts release for Kubernetes to a community-owned bucket.

Ref:
  - kubernetes/release#3729

Temporary allow the Service Agent for the GCB Service from project
`kubernetes-release-test`. This will enable artifacts release for
Kubernetes to a community-owned bucket.
@k8s-ci-robot k8s-ci-robot added the area/infra Infrastructure management, infrastructure design, code in infra/ label Sep 9, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ameukam

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added area/infra/gcp Issues or PRs related to Kubernetes GCP infrastructure approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/terraform Terraform modules, testing them, writing more of them, code in infra/gcp/clusters/ sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. labels Sep 9, 2024
@ameukam
Copy link
Member Author

ameukam commented Sep 9, 2024

/hold
cc @dims @upodroid @BenTheElder

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Sep 9, 2024
Copy link
Member

@BenTheElder BenTheElder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Shall we run the GCB within this project in the future?

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 9, 2024
@ameukam
Copy link
Member Author

ameukam commented Sep 9, 2024

/lgtm

Shall we run the GCB within this project in the future?

IMHO, we should separate project for storage and distribution vs project for release pipelines. It's really hard to track down what/who has access to what.

@ameukam
Copy link
Member Author

ameukam commented Sep 9, 2024

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 9, 2024
@k8s-ci-robot k8s-ci-robot merged commit 5a417fe into kubernetes:main Sep 9, 2024
3 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.32 milestone Sep 9, 2024
@ameukam
Copy link
Member Author

ameukam commented Sep 9, 2024

Deployed:

bindings:
- members:
  - serviceAccount:project-236990870955@storage-transfer-service.iam.gserviceaccount.com
  role: roles/storage.admin
- members:
  - projectEditor:k8s-infra-releases-prod
  - projectOwner:k8s-infra-releases-prod
  role: roles/storage.legacyBucketOwner
- members:
  - projectViewer:k8s-infra-releases-prod
  - serviceAccount:project-236990870955@storage-transfer-service.iam.gserviceaccount.com
  role: roles/storage.legacyBucketReader
- members:
  - projectEditor:k8s-infra-releases-prod
  - projectOwner:k8s-infra-releases-prod
  role: roles/storage.legacyObjectOwner
- members:
  - projectViewer:k8s-infra-releases-prod
  role: roles/storage.legacyObjectReader
- members:
  - serviceAccount:[email protected]
  - serviceAccount:project-236990870955@storage-transfer-service.iam.gserviceaccount.com
  role: roles/storage.objectAdmin
- members:
  - serviceAccount:[email protected]
  role: roles/storage.objectViewer
etag: CAU=

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/infra/gcp Issues or PRs related to Kubernetes GCP infrastructure area/infra Infrastructure management, infrastructure design, code in infra/ area/terraform Terraform modules, testing them, writing more of them, code in infra/gcp/clusters/ cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants