Skip to content

Commit

Permalink
One more test
Browse files Browse the repository at this point in the history
Signed-off-by: GonzaloSaez <[email protected]>
  • Loading branch information
GonzaloSaez committed Nov 5, 2024
1 parent e9684ff commit a67dcc8
Showing 1 changed file with 33 additions and 0 deletions.
33 changes: 33 additions & 0 deletions pkg/controller/podgroup_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -519,6 +519,39 @@ func TestCalculatePGMinResources(t *testing.T) {
corev1.ResourceMemory: resource.MustParse("65Gi"),
},
},
"without worker without priorityClass": {
minMember: 3,
job: &kubeflow.MPIJob{
ObjectMeta: metav1.ObjectMeta{
Name: "test",
},
Spec: kubeflow.MPIJobSpec{
MPIReplicaSpecs: map[kubeflow.MPIReplicaType]*kubeflow.ReplicaSpec{
kubeflow.MPIReplicaTypeLauncher: {
Replicas: ptr.To[int32](1),
Template: corev1.PodTemplateSpec{
Spec: corev1.PodSpec{
Containers: []corev1.Container{
{
Resources: corev1.ResourceRequirements{
Requests: corev1.ResourceList{
corev1.ResourceCPU: resource.MustParse("2"),
corev1.ResourceMemory: resource.MustParse("1Gi"),
},
},
},
},
},
},
},
},
},
},
want: &corev1.ResourceList{
corev1.ResourceCPU: resource.MustParse("2"),
corev1.ResourceMemory: resource.MustParse("1Gi"),
},
},
}
for name, tc := range volcanoTests {
t.Run(name, func(t *testing.T) {
Expand Down

0 comments on commit a67dcc8

Please sign in to comment.