Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove logging for amplitude #76

Merged
merged 1 commit into from
Jul 25, 2023
Merged

feat: remove logging for amplitude #76

merged 1 commit into from
Jul 25, 2023

Conversation

wsbrunson
Copy link
Member

Remove all mention of amplitude so that beaver-logger will no longer support amplitude logging

this is backwards-compatiable, if a client sends amplitude configuration it will just be ignored

@codecov-commenter
Copy link

codecov-commenter commented Jul 24, 2023

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.39%. Comparing base (528d080) to head (6a6a729).
Report is 16 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #76      +/-   ##
==========================================
- Coverage   87.23%   86.39%   -0.84%     
==========================================
  Files           6        6              
  Lines         564      522      -42     
==========================================
- Hits          492      451      -41     
+ Misses         72       71       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@gregjopa gregjopa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great clean up work 💯

@wsbrunson wsbrunson merged commit 3988758 into main Jul 25, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants