Match regular expression with code comment #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is supposed to expect a '<p>' to separate documents, but the regex looks for any tag, creating issues in non-escaped texts.
|
Ping @phikoehn @hieuhoang this is just a copy from Moses. |
|
it seems to be a bug but it's been in there since 2010 so I'm wary that there isn't something else going on. |
|
What @lpla suggests seems reasonable, although the sentence splitter was not designed for texts with html markup in them. I don't fully understand the use of tags (paragraph marking?) I just remove them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is supposed to expect a '<p>' to separate documents, but the regex looks for any tag, creating issues in non-escaped texts.