Some kart-data-ls improvements #895
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Backwards compatible at this point: - You need to add a flag to change kart-data-ls behaviour - kart-data-version is now deprecated, but still works. See #892
craigds
approved these changes
Jul 31, 2023
kart/data.py
Outdated
| repo_desc = ( | ||
| "Empty repository." | ||
| if repo.head_is_unborn | ||
| else "The commit at HEAD has no datasets." |
There was a problem hiding this comment.
Suggested change
| else "The commit at HEAD has no datasets." | |
| else f"The commit at {refish} has no datasets." |
kart/data.py
Outdated
| click.echo(ds_path) | ||
| if with_dataset_types: | ||
| for ds_obj in json_list: | ||
| click.echo(f"{ds_obj['path']}\t({ds_obj['type']}.v{ds_obj['version']})") |
There was a problem hiding this comment.
strings inside strings are hard to read, pull this out somehow. perhaps don't use an f-string, use a .format(**ds_obj)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backwards compatible at this point:
See #892
Checklist: