feat: add support for windows and arm64 platforms #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Harikrishnan Balagopal <[email protected]>
|
Thanks for making a pull request! 😃 |
ashokponkumar
requested changes
Aug 10, 2022
| @@ -15,7 +15,7 @@ | |||
| BINNAME ?= move2kube-api | |||
| BINDIR := $(CURDIR)/bin | |||
| DISTDIR := $(CURDIR)/_dist | |||
| TARGETS := darwin/amd64 linux/amd64 | |||
| TARGETS := darwin/amd64 darwin/arm64 linux/amd64 linux/arm64 windows/amd64 | |||
There was a problem hiding this comment.
Aren't we supporting Darwin amd64? And windows arm64?
There was a problem hiding this comment.
uh it's the same as https://github.com/konveyor/move2kube/blob/main/Makefile#L19
Darwin amd64 is the first one
There was a problem hiding this comment.
windows/arm64 isn't supported by gox yet it seems mitchellh/gox#154
ashokponkumar
approved these changes
Aug 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Harikrishnan Balagopal [email protected]