Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove KWExistVerifier #622

Closed
wants to merge 1 commit into from
Closed

Remove KWExistVerifier #622

wants to merge 1 commit into from

Conversation

sharplet
Copy link
Contributor

@sharplet sharplet commented Aug 3, 2015

This is the first step in a possible solution to #621.

Currently there's this very loose contract between subjects, verifiers and matchers. At the moment it's possible to pair any kind of subject with any kind of verifier. One problem with this is that a plain old subject can be added to an async verifier, even though it's not possible for the subject to be re-evaluated multiple times.

This is the first simplification of the set of types conforming to KWVerifying.


Also, because this is a breaking change, I've created a new 3.0-development branch, which this PR targets. It's going to be helpful to have a place that's safe to put these changes!

@orta
Copy link
Contributor

orta commented May 21, 2016

@sharplet it's worth a re-think about whether you want this in

@sharplet
Copy link
Contributor Author

I think this is only useful as part of a larger set of changes which I'm not really able to commit to. I don't think it's worth merging at this point.

@sharplet sharplet closed this May 22, 2016
@sharplet sharplet deleted the am-i branch May 22, 2016 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants