Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce tf.function retracing #100

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

ymd-h
Copy link
Contributor

@ymd-h ymd-h commented Aug 10, 2020

This PR ensures input arguments of graph function (decorated by tf.function) as tf.Tensor instead of pure Python object, in order to reduce tf.function retracing.

Related with #99

@ymd-h
Copy link
Contributor Author

ymd-h commented Aug 10, 2020

@keiohta

If it is possible, please evaluate with more realistic tasks as well as simple tests.

We want to know whether there are good effects (speed up etc.) at TF2.3 and there are no bad effect (slow down, wrong answer etc.) at TF2.2 and before.

@keiohta
Copy link
Owner

keiohta commented Aug 25, 2020

Thanks for the PR! I'll merge it after checking whether the adding tf.constant deteriorate the performance in terms of time for computing forward and backward propagation of a network.

Unfortunately Anaconda has not supported gpu version of tf2.3 (which I typically use), so please wait for a moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants