Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update share panel - no more ws name allowed #1757

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

briehl
Copy link
Member

@briehl briehl commented Jul 13, 2020

Previously, there was an input of ws_name_or_id in the sharing controls. It took either the workspace name or id of whatever workspace sharing permissions should be modified for.

Now it just takes workspace ids.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 16.149% when pulling 609f2de on briehl:wsname-to-id-share into 1531c4d on kbase:develop.

@briehl
Copy link
Member Author

briehl commented Jul 17, 2020

While going through and writing tests for the sharing panel, found a couple things.

  1. There's no tests right now for that widget.
  2. Due to the flows in how it's written, it's really hard to write tests for. This'll need somewhat of a refactor.
  3. A fairly deep inspection of the code also showed the possibly for a number of untrapped errors, especially when trying to attach a narrative to an organization.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants