Add Keyboard Lock API support (Chromium 68+ only) #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This enables web browser to capture key combos, e.g., Alt+F4, Alt+Tab, and send it to web page. Limitations: 1) Chromium 68+ only; 2) User should click full screen button inside the webpage. API won't work when toggling full screen via F11 or browser menu. 3) HTTPS instead of HTTP. - https://developer.chrome.com/docs/capabilities/web-apis/keyboard-lock - https://developer.mozilla.org/en-US/docs/Web/API/Navigator/keyboard
|
thank you for the pull request, I've entered an internal ticket and tagged for version 1.17 of Kasm Workspaces, so we will be reviewing and doing something with this soon. This will require a lot of testing across hardware, OS, and browser combinations, also languages and keyboard layouts, in order to determine if this is something we can just blindly do without giving the user the ability to disable or putting more caveats in determining when it is enabled or disabled. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables web browser to capture key combos, e.g., Alt+F4, Alt+Tab, and send it to web page.
Note: Fullscreen via web browser menu will invalidate this API support. Use full screen button inside the web page instead.