Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete unused FixedContentsUsingArrayByteLiteral trait #293

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Mingun
Copy link
Contributor

@Mingun Mingun commented Mar 29, 2024

Its usage was removed in 3fcc700

As a next step need to delete method ensureFixedContents from runtime libraries as no longer used

@generalmimon
Copy link
Member

I've already done this on the serialization branch: 83b1fa7

@Mingun
Copy link
Contributor Author

Mingun commented Apr 3, 2024

You yourself said that many small PRs are better than one large one with a thousand things. It seems to me that it is better to merge this one than to wait another N years when serialization will be recognized as ready enough for merge.

@Mingun Mingun force-pushed the remove-fixed-contents branch from 1a45283 to b359866 Compare July 16, 2024 14:21
Its usage was removed in 3fcc700

Need to delete method `ensureFixedContents` from runtime libraries as no longer used
@Mingun Mingun force-pushed the remove-fixed-contents branch from b359866 to 3e1dfb9 Compare September 8, 2024 04:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants