This repository has been archived by the owner on Mar 23, 2024. It is now read-only.
Added fix for rails 5 precompile (sprockets-rails 3) #269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in issue #268, requirejs-rails broke during our production assets:precompile. Our working environment was:
Unfortunately when we did a major upgrade to the following:
And the asset precompile failed.
It mainly seems to be several small removed deprecated functions. Sprockets logical paths seem to contain the biggest changes.
To get both our old environment and new environment to build, we needed this change.
One of the biggest missing pieces to this commit is bower js support. This is mainly because we don't use it. I'm open to suggestions with what to use.
https://github.com/MediaFactual/requirejs-rails/blob/rails5/lib/tasks/requirejs-rails_tasks.rake#L138
Note that this might also solve Issue #257 . We have also been looking forward to #193 since this also breaks a lot of our production asset precompile js files.