.NET 8 SDK Upgrade #56
Conversation
pedropaulovc
changed the title
There was a problem hiding this comment.
Major version-reving Microsoft.Extensions.* dependencies to 8.0.0 is a breaking change for customers (as it can introduce package conflicts or be an environment restriction for them).
I see this is a dependency of your other PR though (at least the 6.0 packages) though. I think what will need to happen is one of two things:
- Multi-target all these packages, adding at least
net6.0TFM and then only in those versions do we add the newIHostApplicationBuilderAPIs
OR - Update to the minimal version that includes the
IHostApplicationBuilder(net6.0?) and then will also need to major version rev these packages.
| <!-- Global --> | ||
| <ItemGroup> | ||
| <GlobalPackageReference Include="Nerdbank.GitVersioning" Version="3.6.133" Condition="'$(EnableGitVersioning)' != 'false'" /> | ||
| <GlobalPackageReference Include="StyleCop.Analyzers" Version="1.2.0-beta.406" Condition="'$(EnableStyleCop)' != 'false'" /> | ||
| <GlobalPackageReference Include="StyleCop.CSharp.Async.Rules" Version="6.1.41" Condition="'$(EnableStyleCop)' != 'false'" /> | ||
| <GlobalPackageReference Include="Microsoft.SourceLink.GitHub" Version="1.1.1" Condition="'$(IsPackable)' != 'false'" /> | ||
| </ItemGroup> | ||
|
|
||
| </Project> | ||
| </Project> |
| <!-- Azure --> | ||
| <ItemGroup> | ||
| <PackageVersion Include="Microsoft.Azure.DurableTask.Core" Version="2.13.0" /> | ||
| <PackageVersion Include="Microsoft.Azure.DurableTask.Core" Version="2.16.1" /> |
There was a problem hiding this comment.
Does this need to be upgraded? I prefer to leave dependencies of a library at a minimum for what the code base needs directly. End users can then decide to pin transitive dependencies at a higher version if they need.
This lets this library capture the widest customer base possible: if a project for some reason cannot update a transitive dependency, this will not force them to.
| @@ -8,7 +8,7 @@ | |||
| <GenerateDocumentationFile>true</GenerateDocumentationFile> | |||
| <EnableStyleCop>true</EnableStyleCop> | |||
| <EnableNETAnalyzers>true</EnableNETAnalyzers> | |||
| <ExtensionsPackageVersion Condition="'$(ExtensionsPackageVersion)' == ''">2.1.0</ExtensionsPackageVersion> | |||
| <ExtensionsPackageVersion Condition="'$(ExtensionsPackageVersion)' == ''">8.0.0</ExtensionsPackageVersion> | |||
There was a problem hiding this comment.
I'd prefer not to force all users of this library onto 8.0.0 versions of Microsoft.Extensions.*. Upgrading major versions of a transitive dependency is a breaking change to users.
This PR updates repo to build with the latest .NET 8 SDK and NuGet packages. Fixes #55.