Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] Adopt formal process for provisional features in JupyterLab core #57

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
# jetbrains ide stuff
*.iml
.idea/

# vscode ide stuff
*.code-workspace
.history
.vscode
47 changes: 47 additions & 0 deletions rfc/provisional_features.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,47 @@
- Alternative names
- Experimental features
- Unstable features
- Preview features

- Abstract

Currently, the api for all new features in JupyterLab has to be frozen within the span of a single PR. This is due to the fact that we follow semver; breaking changes may only occur on the occasion of a major version bump.

This is fine for most features. However, this dev process is causing problems when used for complex features. In particular, features that are expected to be adopted community-wide (eg LabIcon, the extension system, anything to do with user settings) have issues:
- These features (including their API) benefit from wide community feedback, and suffer in the vacumn of 1000+ line single PRs
- The more complex a feature, the more likely it is for its first draft to have at least some poorly formed or ill-considered API

To fix this, I propose that we should adopt a formal process for allowing provisional features in the master branch of JuptyerLab core. This will give the core dev team the opportunity to dogfood and improve complex features before declaring them fit for wider consumption in production code.

Our process should aim for an ideal whereby once a feature is declared mature, it will require no further changes to its API. This in turn would mean fewer breaking changes and less overall maintainence for 3rd party devs.

- Goals
- a better experience for core devs, extension devs, and power users around versioning and compatibility
- easier version migration for core and extensions packages

- What this proposal is not
- a general call to relax semver discipline
- saying that we should hold a community-wide referendum every time someone proposes a new provisional feature

- Terminology
- community: JupyterLab core devs, extension devs, and end users
- API: public interface, including externally visible package structure, function signatures, CLI, and, in the broadest sense, user interface

- Creating a new provisional feature (Python/Typescript sources)
- Create new feature in PR, as per normal
- Add a `_PROVISONAL` suffix to all public API
- Declare the provisional API in the PR issue thread
- Include an outline of future work, including a rough schedule describing the process by which this feature will graduate by the time of the next major release

- Graduating a feature from provisional to mature
- A provisional feature must graduate on the next major release (wrt when it was initally pulled into core) or be removed

- How to treat a provisional feature
- In JupyterLab core code:
- May be called (and in general treated) the same as any other feature
- Ping the original feature dev on any related PR
- If a dev makes changes to a provisional feature, it is their responsibiliy to fix any knock-on effects in core
- In a 3rd party extension:
- May be experimented with
- Should not be used in production code
- Under no circumstances should a provisional feature be used in released code