-
Notifications
You must be signed in to change notification settings - Fork 304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add kube profile spawner #137
Merged
Merged
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
4c92082
Add kube profile spawner
gsemet d28fb2b
clean imports
gsemet a29ad4f
Set minlen to 0 for profile_list
gsemet 3b338ff
disable debug hack
gsemet 63099aa
Allow none for single_user_profile_list
gsemet fceee07
Merge KubeProfileSpawner into KubeSpawner
gsemet b5e0aec
rename variables after review
gsemet 241d47b
Adding example in documentation
gsemet ad2b415
trailing spaces
gsemet 7fbe23c
allow profile value to be callable
gsemet 0281b50
add docstrings
gsemet e076b50
update tox to 3.5 and 3.6
gsemet 8d0a444
Switch to jinja rendering
gsemet b3ea43b
Return '' not None as default for options_form
yuvipanda 8344d1a
Use a single jinja2 template for rendering forms
yuvipanda 02bb801
Update traitlet docs for profile related traitlets
yuvipanda efb48ae
Minor style adjustment
yuvipanda File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,7 +2,7 @@ | |
minversion = 1.6 | ||
skipsdist = True | ||
|
||
envlist = py34 | ||
envlist = py34,py35,py36 | ||
|
||
[flake8] | ||
max-line-length = 100 |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add docstrings for this method?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure ! By the way, do you know how the magic work behind the [_]options_form*? I have no idea how it get called (by tornado?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a JupyterHub feature, see https://github.com/jupyterhub/jupyterhub/blob/a58bea6d933b7bc0bcfe4b08dfff4f31dd2b5909/jupyterhub/spawner.py#L271 and related.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes but the call is for the function self.options_form and ultimately the __default is called...