-
Notifications
You must be signed in to change notification settings - Fork 347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to make boofuzz more compatible #594
base: master
Are you sure you want to change the base?
Conversation
process to start properly (by default 3 seconds just like previously)
@hegusung Sounds great! I'll put this on my queue to review. Which operating systems have you tested on so far with these changes? |
Hi, So boofuzz script was tested on both a Kali linux and a Debian. Process_monitor.py was tested on a Windows 10. there shouldn't be an issue with process_monitor.py on linux because the linux way is always done, il only switches to windows way when an exeption is detected. |
I don't understand what is wrong with stickler-ci |
Seems like it runs into a timeout. Nothing u need to worry about. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @hegusung!
I left some comments below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, I see that this PR is not accepted. |
I took care of your remarks, I also patched the following bug:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apologies for the delayed review.
Thanks for implementing our comments!
I've added one more tiny suggestion.
Could you add some lines about those fixes to the CHANGELOG.rst please?
@@ -50,6 +50,8 @@ def __init__(self, name=None, default_value=None, fuzzable=True, fuzz_values=Non | |||
Fuzzable.name_counter += 1 | |||
self._name = "{0}{1}".format(type(self).__name__, Fuzzable.name_counter) | |||
|
|||
self.index_mutation = 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you think about mutation_index
?
self.index_mutation = 0 | |
self.mutation_index = 0 |
I had these 3 issues when using boofuzz: