Modified OutputBuffer to have an error function to output to stderr #264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Change .fail with errors to .error
|
@FlyingPhish : I provided feedback on some of your proposed changes. Looks good otherwise. |
jtesta
reviewed
Jul 5, 2024
| @@ -108,7 +108,8 @@ def listen_and_accept(self) -> None: | |||
| s.listen() | |||
| self.__sock_map[s.fileno()] = s | |||
| except Exception as e: | |||
| print("Warning: failed to listen on any IPv4 interfaces: %s" % str(e)) | |||
| self.__outputbuffer.error("Warning: failed to listen on any IPv4 interfaces: %s" % str(e)) | |||
| sys.exit(exitcodes.CONNECTION_ERROR) | |||
There was a problem hiding this comment.
Calling sys.exit() wouldn't be appropriate since this is a warning condition, not an error.
| @@ -119,11 +120,12 @@ def listen_and_accept(self) -> None: | |||
| s.listen() | |||
| self.__sock_map[s.fileno()] = s | |||
| except Exception as e: | |||
| print("Warning: failed to listen on any IPv6 interfaces: %s" % str(e)) | |||
| self.__outputbuffer.error("Warning: failed to listen on any IPv6 interfaces: %s" % str(e)) | |||
| sys.exit(exitcodes.CONNECTION_ERROR) | |||
There was a problem hiding this comment.
Similar to above, this is not a hard error, so calling sys.exit() isn't appropriate.
|
@FlyingPhish: if you're able to make the minor changes I requested in the review, and resolve the merge conflict, I can go ahead and merge this. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added error function to OutputBuffer to output errors to stderr, then changed a bunch of .fails where the values were error: or [exception].
Have tested and code appears to work as intended.