Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: adjust font stack and fix typo in css #54

Merged
merged 2 commits into from
May 31, 2024

Conversation

SethFalco
Copy link
Member

@SethFalco SethFalco commented May 31, 2024

Font Stack

Instead of using a font stack that I picked out myself, we instead use one derived from Modern Font Stacks.

I made the following changes:

  • Replace Nimbus Sans with Liberation Sans, which renders more consistently between browsers.
  • Omit Inter, which causes too much layout shift compared to other typefaces in the PDF export, which isn't favorable given we can't have a fluid/responsive design there.

This does incidentally make PDF exports notably smaller in some cases, for example rendering with Roboto instead of Nimbus Sans reduced the output by 30% for me.

@SethFalco SethFalco merged commit b7cc0ad into jsonresume:main May 31, 2024
1 check passed
@SethFalco SethFalco deleted the chores-fonts branch May 31, 2024 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant