Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add libzimg #386

Merged
merged 2 commits into from
Feb 29, 2024
Merged

Conversation

emmanuelgeoffray
Copy link
Contributor

Zimg is very useful to manipulate HDR videos. I expect it to be mandatory for all projects in the next few months.

I've isolated the zimg part in #318

I've tested the build 6.1/ubuntu2004.

@jrottenberg
Copy link
Owner

Looks very promising, thank you, can you rebase to get the build going ?

@emmanuelgeoffray
Copy link
Contributor Author

Looks very promising, thank you, can you rebase to get the build going ?

done

@jrottenberg
Copy link
Owner

jrottenberg commented Feb 25, 2024

No --enable-libzimg on ffmpeg compile parameters ?

@jrottenberg
Copy link
Owner

I've tested your branch, added the flag and got a successful build for one variant, so worth testing the rest.

@emmanuelgeoffray
Copy link
Contributor Author

oops, forgot the flag, I've added it now @jrottenberg

@jrottenberg
Copy link
Owner

Great thank you !

@jrottenberg jrottenberg merged commit 782e2d0 into jrottenberg:main Feb 29, 2024
@emmanuelgeoffray emmanuelgeoffray deleted the feat/libzimg branch February 29, 2024 07:55
@jrottenberg
Copy link
Owner

ok it worked great except on 2.8:

#41 [build 35/36] RUN          DIR=/tmp/ffmpeg && cd ${DIR} &&         ./configure         --disable-debug         --disable-doc         --disable-ffplay         --enable-avresample         --enable-fontconfig         --enable-gpl         --enable-libass         --enable-libbluray         --enable-libfdk_aac         --enable-libfreetype         --enable-libmp3lame         --enable-libopencore-amrnb         --enable-libopencore-amrwb         --enable-libopus         --enable-libtheora         --enable-libvidstab         --enable-libvorbis         --enable-libvpx         --enable-libwebp         --enable-libx264         --enable-libx265         --enable-libxvid         --enable-libzimg         --enable-libzmq         --enable-nonfree         --enable-openssl         --enable-postproc         --enable-shared         --enable-small         --enable-version3         --extra-cflags="-I/opt/ffmpeg/include"         --extra-ldflags="-L/opt/ffmpeg/lib"         --extra-libs=-ldl         --prefix="/opt/ffmpeg" &&         make clean &&         make &&         make install &&         make tools/zmqsend && cp tools/zmqsend /opt/ffmpeg/bin/ &&         make distclean &&         hash -r &&         cd tools &&         make qt-faststart && cp qt-faststart /opt/ffmpeg/bin/
#41 0.542 Unknown option "--enable-libzimg".
#41 0.542 See ./configure --help for available options.

Easy fix, thx again !

@emmanuelgeoffray
Copy link
Contributor Author

ok it worked great except on 2.8:

#41 [build 35/36] RUN          DIR=/tmp/ffmpeg && cd ${DIR} &&         ./configure         --disable-debug         --disable-doc         --disable-ffplay         --enable-avresample         --enable-fontconfig         --enable-gpl         --enable-libass         --enable-libbluray         --enable-libfdk_aac         --enable-libfreetype         --enable-libmp3lame         --enable-libopencore-amrnb         --enable-libopencore-amrwb         --enable-libopus         --enable-libtheora         --enable-libvidstab         --enable-libvorbis         --enable-libvpx         --enable-libwebp         --enable-libx264         --enable-libx265         --enable-libxvid         --enable-libzimg         --enable-libzmq         --enable-nonfree         --enable-openssl         --enable-postproc         --enable-shared         --enable-small         --enable-version3         --extra-cflags="-I/opt/ffmpeg/include"         --extra-ldflags="-L/opt/ffmpeg/lib"         --extra-libs=-ldl         --prefix="/opt/ffmpeg" &&         make clean &&         make &&         make install &&         make tools/zmqsend && cp tools/zmqsend /opt/ffmpeg/bin/ &&         make distclean &&         hash -r &&         cd tools &&         make qt-faststart && cp qt-faststart /opt/ffmpeg/bin/
#41 0.542 Unknown option "--enable-libzimg".
#41 0.542 See ./configure --help for available options.

Easy fix, thx again !

sorry for this.
Do you want me to fix it or are you going to do it ?

I guess the fix would be to make it conditional on the version in the section below
image

@jrottenberg
Copy link
Owner

jrottenberg commented Mar 1, 2024

I'll have time this weekend, but if you want to take a stab at it before... No rush though I think the 2.8 variants are not building for another reason anyway...

;-)

;-p

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants