-
Notifications
You must be signed in to change notification settings - Fork 461
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updated ffmpeg-4.2 libs to newest versions #209
base: main
Are you sure you want to change the base?
Conversation
Oh that's great thank you, but can you make the change inside the template folder, so all variants benefits from them ? |
what sorcery is this xD? templates? sure can do. EDIT: answer to myself. run ./update.py |
856da9b
to
8ceaf28
Compare
git closed the PR after i reset the commit |
this involved updating version numbers, changing some download URLs, matching the respective sha256sums and adjusting build command chains.
while watching the checks running the following occured: centos builds "completed" earlier than expected and reported success despite the non-zero return during the x264 compilation step. may be a bug with the build system. after the build error it stopped compiling the other libraries. The issue for the centos version is that the latest x264-stable requires version 2.13 of nasm while the current centos:7 base only provides nasm version 2.10. |
If you were to rebase this and build it again the centos problem would likely be resolved. The base image for the centos containers is centos:8 which has cmake 3 as its packaged cmake version. |
this involved updating version numbers, changing some download URLs, matching the respective sha256sums and adjusting build command chains.
welp libass doesnt build on CentOS... will investigate this further and maybe even downgrade libass. EDIT: a short Google Search revealed that fribidi is in fact available for CentOS and only needs to be added to the CentOS template. Will do so in a new commit. |
a65efec
to
79a11a4
Compare
And with the new dependency, CentOS's package manager now tries to install a package called epel-release which adds a new repo. But when it tries to update its DB from that repo it fails. Just whyyy....
But hey it only happened in the 4_2 centos build. Hopefully that's just a random hiccup. |
I updated most of the libraries built from source in the alpine-4.2 image.
This involved changing version numbers, updating sha256sums, replacing URLs and adjusting build commands.
I have built the alpine image on my local machine.
I've made this PR to let you know that I'm working on this. I do intend to port this patch over to other images with the different OS base. But I would appreciate help on this.