Add conversions of num/int/rat/real/word that evaluate expressions using Compute #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aqjune-aws
force-pushed
the
reduce_conv
branch
from
0ea85f4
to
3a62e0a
Compare
…ing Compute This patch adds conversions of num/int/rat/real/word that use the Compute module to evaluate expressions. They are named `*_COMPUTE_CONV` and uses the 'weak' reduction (`Compute.WEAK_CBV_CONV`). Additionally, an if-then-else expression is configured to be reduced only when the branch is constant. These new conversions are different from - `*_RED_CONV` because `*_RED_CONV` cannot recursively traverse subexpression (e.g., `NUM_RED_CONV` cannot reduce `` `1 + (2 + 3)` ``) - Also different from `*_REDUCE_CONV` because `*_REDUCE_CONV` tries to recursively reduce every subexpression (e.g., `` `if unknown_cond then 1 + 2 else 3 + 4` ``, `` `\x. x + (1 + 2)` ``). This also makes github workflow fail if any command fails.
|
I refactored this patch a bit in order to make |
|
This is great, thank you! I like the way the xxx_COMPUTE_CONV and the existing xxx_RED_CONV are factored through a common pattern+conversion list. I've tried out a few examples and it all works smoothly, as well as saving a lot of computation in cases where the reduction strategy is more efficient. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds conversions of num/int/rat/real/word that use the Compute module to evaluate expressions.
They are named
*_COMPUTE_CONVand uses the 'weak' reduction (Compute.WEAK_CBV_CONV).Additionally, an if-then-else expression is configured to be reduced only when the branch is constant.
These new conversions are different from
*_RED_CONVbecause*_RED_CONVcannot recursively traverse subexpression (e.g.,NUM_RED_CONVcannot reduce`1 + (2 + 3)`)*_REDUCE_CONVbecause*_REDUCE_CONVtries to recursively reduce every subexpression (e.g.,`if unknown_cond then 1 + 2 else 3 + 4`,`\x. x + (1 + 2)`).