Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for countable error in PHP 7.2 in find() #600

Closed
wants to merge 1 commit into from
Closed

Fix for countable error in PHP 7.2 in find() #600

wants to merge 1 commit into from

Conversation

starfishpatkhoo
Copy link

@starfishpatkhoo starfishpatkhoo commented Jan 4, 2019

  1. $args is always an array from func_get_args()

  2. static::find_by_pk() expects $args to be an array

So why are we trying to change $args from an array into a ... non-array?

This fixes the countable error in PHP 7.2 #588 #596

2. static::find_by_pk() expects $args to be an array

So why are we trying to change an array into a normal variable?

This fixes the countable error in PHP 7.2
@ysc2015
Copy link

ysc2015 commented Jun 25, 2019

To fix this error i just commented the code :

//find by pk
elseif (1 === count($args) && 1 == $num_args)
	$args = $args[0];

@starfishpatkhoo starfishpatkhoo closed this by deleting the head repository Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants