[5.2] mod_menu php fixes

[chmst]

Pull Request for Issue #44317 .

Summary of Changes

Set Variables correctly

Testing Instructions

see #44317

Actual result BEFORE applying this Pull Request

Deprecated messages and Undefined Property messages

Expected result AFTER applying this Pull Request

no messages

Link to documentations

Please select:

• Documentation link for docs.joomla.org:

• No documentation changes for docs.joomla.org needed

• Pull Request link for manual.joomla.org:

• No documentation changes for manual.joomla.org needed

[brianteeman]

I have tested this item 🔴 unsuccessfully on 5f70630

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44318.}

[brianteeman]

After applying the PR most of the core menu module disapears

[chmst]

I change this to draft as the behaviour with recover seems to be wrong.

[brianteeman]

Still not correct.

With this PR
Before enabling recovery

After enabling recovery

[chmst]

Thank you for testing. I cannot replicate that - in my test it is:

[fgsw]

I have tested this item ✅ successfully on d62377f

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44318.}

[brianteeman]

This video shows that the recovery mode does not work.

chrome_tUW7ufmkPe.mp4

[fgsw]

I have not tested this item.

@brianteeman now i understand, what you meant.

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44318.}