feat!: require send as well as sync #50
Merged
+4
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the lazy_static feature "spin_no_std" is enabled, the bounds of Send is required This may happen if another dependency adds that feature, then cargo unifies the two dependency trees erroneously, causing a compile error requiring Send on Runtime. This is technically a breaking change in case anyone had a Sync but not Send type implementing Function See more: rust-lang-nursery/lazy-static.rs#204
|
I'm OK with this but would definitely make it a breaking change, which is not a bad thing! |
|
Hello! Is there a chance that this PR could get merged soon and a release made? The underlying issue is blocking us in Krill from upgrading some dependencies leading to quite a lot of duplicate library crates being used slowing down compilation and bloating the binary. |
cetra3
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the lazy_static feature "spin_no_std" is enabled, the bounds of Send is required This may happen if another dependency adds that feature, then cargo unifies the two dependency trees erroneously, causing a compile error requiring Send on Runtime.
This is technically a breaking change in case anyone had a Sync but not Send type implementing Function. May want to consider a minor version bump.
See more: rust-lang-nursery/lazy-static.rs#204