Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed version of SSZipArchive to make it build with current version of ios #20

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

fabiofabbri84
Copy link

We wanted to use this plugin on a Cordova project, but it was not building with current version of the ios platform.

I'm not sure 100% of the cause, but I think this is due to the fact that the plugin is using an old version of SSZipArchive that is not compatible with current version of Xcode.

Removing the SSZipArchive version number, it works.

I'm not sure if it's better to specify another version of SSZipArchive, but this worked for me and I'm happy with that.

@willPHPwork
Copy link

Any updates on this?

@fabiofabbri84
Copy link
Author

fabiofabbri84 commented Sep 25, 2024

Well, if you need to use this fixed version right now you can:

cordova plugin remove com.jjdltc.cordova.plugin.zip

cordova plugin add "https://github.com/cimatti/jjdltc-cordova-plugin-zip#ios-2024-compatibility"

Or you can use our master branch that includes also Electron support: (see #21)

cordova plugin add https://github.com/cimatti/jjdltc-cordova-plugin-zip

@willPHPwork
Copy link

Do you have this as an NPM plugin by chance?

@fabiofabbri84
Copy link
Author

For now we don't plan to fork/take over this plugin, so we think is better to not create yet another npm package.

Adding the plugin by git url should work fine, why you need a npm package? Do you see any issue I didn't consider?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants