Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for column separators in arrays (#127). #168

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

aweinstock314
Copy link

No description provided.

- Add [ColumnSeparator] to EArray.
- Readers.MathML can generate any of {CSNone, CSDashed, CSSolid}, which should round-trip through Writers.MathML
- {Readers,Writers}.TeX only support {CSNone, CSSolid}
- Readers.OMML currently generates CSNone, and Writers.OMML doesn't emit ColumnSeparator information
… an off-by-1 in the TeX reader, and add the augmented matrix example to the test suite.
-- the contents of the lines. All of these lists should be
-- the same length.
-- the contents of the lines; the third gives the type of separator between
-- columns. The first two of these lists should be the same length, the last
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't quite right, is it? Rather, each ArrayLine should be the same length as the list of alignments.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conceptually, I'd prefer

EArray [Alignment] [ColumnSeparator] [ArrayLine]

with the content at the end and the "form" at the beginning.

@jgm
Copy link
Owner

jgm commented Jan 10, 2021

Thanks - this looks good! I'd suggest changing the parameter order in EArray as noted.
Also, although it isn't universally enforced, the general code style is hard-wrapping within 80 columns. I wouldn't insist on this but it would be nice if it could be reformatted to match this.

@jgm
Copy link
Owner

jgm commented Apr 25, 2021

@aweinstock314 - did you plan to go forward with this? I think only a few changes are needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants