Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lock config during import #1176

Merged
merged 1 commit into from
Apr 24, 2024
Merged

Lock config during import #1176

merged 1 commit into from
Apr 24, 2024

Conversation

yahavi
Copy link
Member

@yahavi yahavi commented Apr 20, 2024

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • All static analysis checks passed.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.

The JFrog CLI config file is presently only locked before jf c add, jf c edit, jf c rm, and jf c use commands. This pull request includes a lock before jf c import to prevent the config file from being corrupted when importing multiple server configurations simultaneously.

Fix jfrog/setup-jfrog-cli#141 and possibly jfrog/setup-jfrog-cli#94.

Copy link
Contributor

👍 Frogbot scanned this pull request and did not find any new security issues.


@yahavi yahavi merged commit 5ef50ba into jfrog:dev Apr 24, 2024
6 of 7 checks passed
@yahavi yahavi deleted the lock-import branch April 24, 2024 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Paralell jfrog-setup-cli mess up the jfrog-cli.conf.v6 format
2 participants