fix: 🐛 if a validator strategy returns two ways use the first #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this library, I encountered an issue where certain inputs, such as a CPF could also resemble a phone number. For instance:
The validator mistakenly returns:
['cpf', 'phone']This situation poses a problem when attempting to normalize the input for a PIX transaction. For example:
normalize('000000000')Without passing a strategy explicitly, the
"as"parameter in the normalize method will be null, leading to a validation error.The solution is to return the first strategy on validator to normalize.