feat: update tf versions in dockerfiles

[mentlak0]

• upgrade TF versions in docker images

[mentlak0]

/ cc @tomhobson

[jenkins-x-bot]

Hi @mentlak0. Thanks for your PR.

I'm waiting for a jenkins-x member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository.

[jenkins-x-bot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign garethjevans
You can assign the PR to them by writing /assign @garethjevans in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[tomhobson]

/ok-to-test

[tomhobson]

/cc @msvticket

[msvticket]

What is the purpose of this PR? As far as I can see these Dockerfiles are not in use any more.

[mentlak0]

@msvticket Hi, I am upgrading terraform-jx-azure to be up to date with the azurerm provider and terraform version since the k8s 1.27+ upgrades (there are a few resource behaviour changes).

The image being changed in the PR gets pulled in to the terraform pipelineRun

https://github.com/jenkins-x/jx3-pipeline-catalog/blob/master/tasks/terraform/pullrequest.yaml

The version is set at 1.12.0, therefore when trying to upgrade it fails.

[msvticket]

But the image is not built anymore. As you can see here no image has been pushed in over a year. First it was commented out from jenkins-x-release.yaml with an initial comment saying:

# Commenting these for now, as custom images are a bit complicated to do in the new tf operator versions

Later the block was removed entirely.

[mentlak0]

@msvticket Thanks for that. I see, this may be a problem then with trying to upgrade terraform versions for the cluster terraform repos and trying to avoid drift etc. Do you have any suggestions?

[msvticket]

Good question. One option would be to upgrade the terraform operator. New versions seem to have a design where adding custom plugins (actually jobs) with custom images is easy, so we should be able to use the default image for the terraform stuff and then use for example the jx-boot image for the equivalent of the postrunScript (which isn't supported anymore).

See http://tf.galleybytes.com/

There is supposed to be a migration guide, but I can't find it. I created an issue regarding that: GalleyBytes/terraform-operator#163

[mentlak0]

@msvticket Thanks for the reply. Especially with k8s default version being set (and upgrades made) on the reports. It is important to maintain changes in the Terrform to reflect work that was completed. Will look into the suggestions you have made in due time.