fix: escape URL path to prevent issues with unescaped characters when use webhook #1334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
secriy
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes an issue with the URL path not being properly escaped when constructing an HTTP request. It updates the code to use u.EscapedPath() instead of u.Path to ensure that special characters in the URL path are correctly escaped.
Motivation
I want to add a newline character (%0A) to the URL path. In the current implementation (master branch), there is a hacky workaround that uses %250A (where %0A would be expected) to achieve this. This behavior is incorrect and caused by the lack of proper escaping for the path. By switching to u.EscapedPath(), newline characters and other special characters are correctly encoded, eliminating the need for double-encoding workarounds.
Additional Notes
None