Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(circle): [WIP] ACircle component with Knob, Chart, Spinner and useTrigonometry. #123

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

ManUtopiK
Copy link
Contributor

I compiled some stuff I got to work with svg. It's a work in progress.
I pull it here to share it if some people want to work on it...

image

image

@jd-solanki
Copy link
Owner

Knob looks awesome ❤️

@husayt
Copy link

husayt commented Mar 30, 2023

This is really cool stuff. Let's not let this effort to stall and get over the line. Even if there are things left to do, this is good to start with and will get the feedback to drive in right direction.

@husayt
Copy link

husayt commented Jun 4, 2023

@jd-solanki it has been some time since this PR. Any particular reason this is not merged? Generally it is a good practice to provide a feedback on the PR, so that contributor is aware of the reasons why it is not accepted.

@jd-solanki
Copy link
Owner

Hi @husayt

As this is a draft PR I guess some work is left to complete. That's the one & only reason I haven't reviewed this.

@husayt
Copy link

husayt commented Jun 7, 2023

@jd-solanki my bad. @ManUtopiK have you abandoned this or it is still WIP. it was such a fresh idea, was keen to have this as part of the library.

@ManUtopiK
Copy link
Contributor Author

Hi!
I use some parts of this PR to a side project, but it could became a component.
If you are really interested, I could work on it again, but not before two weeks...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants