feat: add module-info.java #6
Conversation
There was a problem hiding this comment.
Hi @7agustibm it looks good. I am wondering if u were able to create all the automatic modules that comes from the dependencies? if so, would be good to add them here.
When I tried to use it was very painful and I ended up using the graphql-java lib instead.
To offer a good experience it would be good to add those automatic modules declaration as part of the build with maven or Gradle. Thoughts?
Update
It seems that those issues would be fixeed with the module-info.java
My references:
https://github.com/javalin/javalin/pull/1908/files
https://github.com/javalin/javalin-rendering/pull/25/files
|
@7agustibm are you waiting for me? I think should have merging rights? |
|
Hi @tipsy! Yes, I have merging rights. But I'm doing tests to validate that everything is right and I'm seeing that we use Coroutines and it has some problems with JPMS. |
Add JPMS.