Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make using balance mode consistent with mask mode #30

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pyrmont
Copy link

@pyrmont pyrmont commented Apr 25, 2023

Mask mode is toggled using an enable function and a disable function. Despite being a similar binary mode, balance mode is toggled using a single function that takes an argument specifying the status of the mode. No preference is expressed as to which API is better but since balance mode has only recently been added, this change makes balance mode match the approach taken by mask mode.

Mask mode is toggled using an enable function and a disable function.
Despite being a similar binary mode, balance mode is toggled using a
single function that takes an argument specifying the status of the
mode. No preference is expressed as to which API is better but since
balance mode has only recently been added, this change makes balance
mode match the approach taken by mask mode.
@pyrmont pyrmont force-pushed the cleanup.balancemode-consistency branch from 507f42d to 2e85007 Compare February 9, 2024 07:23
@pyrmont
Copy link
Author

pyrmont commented Feb 9, 2024

@jart Not sure if this is a wontfix (no hard feelings if it is) but I've rebased against current master in case that was an issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant