Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #734: Fix possible concurrent modification problem #736

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions api/src/main/java/jakarta/mail/internet/ParameterList.java
Original file line number Diff line number Diff line change
Expand Up @@ -429,9 +429,8 @@ private void combineMultisegmentNames(boolean keepConsistentOnFailure)
charset = vv.charset;
} else {
if (charset == null) {
// Happened when some invalid string is used.
// Details in Issue#734
throw new ParseException("Invalid parameter list string.");
// should never happen
it.remove(name);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Iterator remove doesn't take are arguments

it.remove()

}
}
decodeBytes(vv.value, bos);
Expand Down