Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: updated _parse_query to use ivy's set_item to use get_item as it's optimized now #28582

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

fix: updated _parse_query to use ivy's set_item to use get_item as it's optimized now #28582

wants to merge 7 commits into from

Conversation

vedpatwardhan
Copy link
Contributor

No description provided.

@Ishticode
Copy link
Contributor

I've removed to_scalar call in _numel. This should be mostly fine but I am expecting ivy.pul_along_axis to fail as it uses _numel expecting it to be scalar for all backends. But will fix any other related changes. @vedpatwardhan

@vedpatwardhan
Copy link
Contributor Author

I've removed to_scalar call in _numel. This should be mostly fine but I am expecting ivy.pul_along_axis to fail as it uses _numel expecting it to be scalar for all backends. But will fix any other related changes. @vedpatwardhan

sounds good! Could you please make necessary changes to ivy.put_along_axis to get it fixed as well? Thanks @Ishticode 😄

@vedpatwardhan
made a few more changes to set_item and ivy.shape, got ivy.shape to r…
dea0111 
…eturn a tensor by default if executing in graph mode to avoid breaking torch
@Ishticode Ishticode mentioned this pull request Mar 16, 2024
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Ishticode Ishticode

Labels
Ivy Functional API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vedpatwardhan @Ishticode @ivy-leaves