Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed the " ModuleNotFoundError" and also the refactored the test_elu for the ELU class, to show the tests now run #28162

Closed
wants to merge 3 commits into from

Conversation

mosesdaudu001
Copy link
Contributor

PR Description

The purpose of the PR is to get the stateful test up and running. I was able to do that but I noticed that for ELU, the alpha was passed as a keyword argument was not positioned correctly, which was why I changed the position. I do not think we need to pass in the method_num_positional_args for each test, as it is already generated correctly in the handle_method function. Except there is another reason I may not know. I do not think we should be adding it for every test case.

Related Issue

close #28136

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks

Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.

Conventional Commit PR Title

In order to be considered for merging, the pull request title must match the specification in conventional commits. You can edit the title in order for this check to pass.
Most often, our PR titles are something like one of these:

  • docs: correct typo in README
  • feat: implement dark mode"
  • fix: correct remove button behavior

Linting Errors

  • Found type "null", must be one of "feat","fix","docs","style","refactor","perf","test","build","ci","chore","revert"
  • No subject found

@ivy-leaves ivy-leaves added the Bug Report Report bugs detected in Ivy. label Feb 2, 2024
Copy link
Contributor

@vedpatwardhan vedpatwardhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @mosesdaudu001, thanks for making the changes to test_elu, could you please do the same changes for the other stateful tests as well? Seems like quite a lot of them are failing due to the same reason. Thanks 😄

@NripeshN
Copy link
Contributor

Hey @mosesdaudu001,
Is this PR being worked upon?

@mosesdaudu001
Copy link
Contributor Author

Really sorry about the hold up. Recently circumstances have made me unavailable. I should have completed the task, but I’ve not really had the time. My bad 😥 @vedpatwardhan

if @soma2000-lang still wants it. I’m happy to drop it for him. Sorry about the hold up mate 😅

@soma2000-lang
Copy link
Contributor

soma2000-lang commented Feb 25, 2024

Really sorry about the hold up. Recently circumstances have made me unavailable. I should have completed the task, but I’ve not really had the time. My bad 😥 @vedpatwardhan

if @soma2000-lang still wants it. I’m happy to drop it for him. Sorry about the hold up mate 😅

I can take it up

@NripeshN NripeshN closed this Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Report Report bugs detected in Ivy.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Getting the stateful tests up and running
6 participants