Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to smooth control for plots #3223

Closed
shcheklein opened this issue Feb 5, 2023 · 6 comments
Closed

Improvements to smooth control for plots #3223

shcheklein opened this issue Feb 5, 2023 · 6 comments
Assignees
Labels
A: plots Area: plots webview, side panel and everything related

Comments

@shcheklein
Copy link
Member

shcheklein commented Feb 5, 2023

After smooth template became default we need to find another way to control smoothness:

  • We should be able to save the value in between sessions. Atm, if you open plots -> change the value -> close plots -> open them again you are loosing your changes to the value.
  • On some high contrast light / dark themes it blends with the background behind the plots. Should be the color of the plot canvas instead.
  • Can we align the control to the corner and make the background transparent?
  • Should be a button per plot that open that control and/or control per section that can change all at once?

Screenshot 2023-02-04 at 3 50 07 PM

@shcheklein shcheklein added the A: plots Area: plots webview, side panel and everything related label Feb 8, 2023
@mattseddon
Copy link
Member

Can we close this after #3250?

@shcheklein
Copy link
Member Author

@mattseddon I've updated the description and repurposed the ticket a bit.

@shcheklein shcheklein changed the title Find a better way to show smooth control for plots Improvements to smooth control for plots Feb 13, 2023
@shcheklein shcheklein added priority-p2 Future feature, less priority for now and removed priority-p2 Future feature, less priority for now labels Mar 7, 2023
@mattseddon
Copy link
Member

Related to #3837

@domoritz
Copy link

All state in Vega charts is stored in the data or the signals which you can read/write using the Vega View API. You should be able to use this functionality to store the state across chart changes. You can also use the same API to coordinate changes across multiple charts to address the last point. It may even be possible to bind the param for smoothing from multiple Vega views to the same input DOM element (https://vega.github.io/vega/docs/signals/#bind) but I haven't tried that.

@julieg18
Copy link
Contributor

julieg18 commented Jul 5, 2023

Can we align the control to the corner and make the background transparent?

Tried this, and while it looked ok on larger plots, it looks buggy on smaller plots:

image image

@julieg18
Copy link
Contributor

As discussed synchronously, going to close this as most tasks have been completed and we aren't planning to add a across-plot smooth control feature at the moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: plots Area: plots webview, side panel and everything related
Projects
None yet
Development

No branches or pull requests

4 participants