Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plots: Update legend suppression (smooth template) #3226

Closed
mattseddon opened this issue Feb 6, 2023 · 4 comments
Closed

Plots: Update legend suppression (smooth template) #3226

mattseddon opened this issue Feb 6, 2023 · 4 comments
Assignees
Labels
A: integration Area: DVC integration layer A: plots Area: plots webview, side panel and everything related priority-p1 Regular product backlog

Comments

@mattseddon
Copy link
Member

Now that the default template is a smooth plot our (flaky) method of suppressing the legend and then reinstating it in a zoomed plot no longer works as expected/produces a nice result:

image

image

We need to decide whether or not we are going to continue attempting to display the legend/data in the old way or if we are going to take a different approach. If we are going to change then we need suggestions for how to integrate the sidebar/rest of the app.

After deciding on the approach we will need to spend time updating the implementation.

Note: I have spent some time looking into a fix/patch for the change and it appears that the change will be non-trivial. I think we are going to have to start walking through the template hierarchy to update the different color/strokedash/shape entries.

@mattseddon mattseddon added A: plots Area: plots webview, side panel and everything related A: integration Area: DVC integration layer labels Feb 6, 2023
@mattseddon
Copy link
Member Author

Related to #3223

@shcheklein
Copy link
Member

It should be fixed/researched along with iterative/dvc-render#115

@shcheklein
Copy link
Member

Looking into this. I'll try to remove the legend objects from the Spec as we do with titles.

@shcheklein
Copy link
Member

Closing for now in favor of iterative/dvc-render#115 (we can reopen if @dberenbaum decides other way).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: integration Area: DVC integration layer A: plots Area: plots webview, side panel and everything related priority-p1 Regular product backlog
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants