Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set maintenance behavior to TERMINATE when using GPU #755

Closed
wants to merge 1 commit into from
Closed

Set maintenance behavior to TERMINATE when using GPU #755

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions iterative/gcp/provider.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,11 +86,6 @@ func ResourceMachineCreate(ctx context.Context, d *schema.ResourceData, m interf
return err
}

instanceHostMaintenanceBehavior := "MIGRATE"
if instanceIsPreemptible {
instanceHostMaintenanceBehavior = "TERMINATE"
}

instanceAccelerators := []*gcp_compute.AcceleratorConfig{}
if instanceType["accelerator"]["count"] != "0" {
acceleratorType, err := service.AcceleratorTypes.Get(project, instanceZone, instanceType["accelerator"]["type"]).Do()
Expand All @@ -112,6 +107,11 @@ func ResourceMachineCreate(ctx context.Context, d *schema.ResourceData, m interf
}
}

instanceHostMaintenanceBehavior := "MIGRATE"
if instanceIsPreemptible || len(instanceAccelerators) > 0 {
instanceHostMaintenanceBehavior = "TERMINATE"
}

network, err := service.Networks.Get(project, networkName).Do()
if err != nil {
networkDefinition := &gcp_compute.Network{
Expand Down