Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set maintenance behavior to TERMINATE when using GPU #755

Closed
wants to merge 1 commit into from
Closed

Set maintenance behavior to TERMINATE when using GPU #755

wants to merge 1 commit into from

Conversation

0x2b3bfa0
Copy link
Member

@0x2b3bfa0 0x2b3bfa0 commented Jul 3, 2023 •
edited
Loading

Closes iterative/cml#1398 by backporting the following task code:

terraform-provider-iterative/task/gcp/resources/resource_instance_template.go

Lines 115 to 118 in a0fb6be

hostMaintenanceBehavior := "MIGRATE"
if isPreemptible || len(accelerators) > 0 {
hostMaintenanceBehavior = "TERMINATE"
}

@0x2b3bfa0 0x2b3bfa0 added bug Something isn't working cloud-gcp Google Cloud resource-runner iterative_runner TF resource resource-machine iterative_machine TF resource labels Jul 3, 2023
@0x2b3bfa0 0x2b3bfa0 requested a review from a team July 3, 2023 03:40
@0x2b3bfa0 0x2b3bfa0 self-assigned this Jul 3, 2023
@0x2b3bfa0 0x2b3bfa0 mentioned this pull request Jul 3, 2023
Open
@0x2b3bfa0
Copy link
Member Author

Major blunder; already part of the existing logic! 🤦🏼‍♂️

@0x2b3bfa0 0x2b3bfa0 closed this Jul 3, 2023
@0x2b3bfa0 0x2b3bfa0 deleted the maintenance-behavior-terminate branch July 3, 2023 03:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@0x2b3bfa0 0x2b3bfa0

Labels
bug Something isn't working cloud-gcp Google Cloud resource-machine iterative_machine TF resource resource-runner iterative_runner TF resource
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot create certain GCP GPU instances
1 participant
@0x2b3bfa0