Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Big/small tall/short modification #894

Merged
merged 30 commits into from
Aug 13, 2020
Merged

Conversation

paynesa
Copy link
Collaborator

@paynesa paynesa commented Jul 10, 2020

closes #889
closes #832
opens #954

@codecov
Copy link

codecov bot commented Jul 10, 2020

Codecov Report

Merging #894 into master will increase coverage by 2.78%.
The diff coverage is 93.54%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #894      +/-   ##
==========================================
+ Coverage   82.98%   85.76%   +2.78%     
==========================================
  Files          87       87              
  Lines        9357     9935     +578     
  Branches     1966     2129     +163     
==========================================
+ Hits         7765     8521     +756     
+ Misses       1255     1072     -183     
- Partials      337      342       +5     
Impacted Files Coverage Δ
adam/learner/__init__.py 87.01% <ø> (-8.64%) ⬇️
adam/learner/integrated_learner.py 94.16% <ø> (+1.35%) ⬆️
adam/learner/learner_utils.py 86.20% <0.00%> (-0.31%) ⬇️
adam/learner/objects.py 86.18% <ø> (+26.46%) ⬆️
adam/learner/prepositions.py 80.73% <ø> (ø)
adam/learner/template_learner.py 90.84% <ø> (-0.94%) ⬇️
adam/learner/verbs.py 94.66% <ø> (ø)
adam/perception/perception_graph.py 83.09% <ø> (+9.85%) ⬆️
adam/situation/templates/phase1_templates.py 89.49% <ø> (+0.42%) ⬆️
adam/learner/object_recognizer.py 81.27% <50.00%> (+0.67%) ⬆️
... and 38 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 764b317...460a2ad. Read the comment docs.

@paynesa paynesa marked this pull request as ready for review July 10, 2020 18:21
@paynesa
Copy link
Collaborator Author

paynesa commented Jul 14, 2020

Waiting for #893 -- currently there's a hack that covers this to allow it compile and run but it's just a bool and #893 will give a more complete fix.

@paynesa
Copy link
Collaborator Author

paynesa commented Jul 20, 2020

Pending #751 and #792; see #920 for fuller explanation

adam/learner/object_recognizer.py Outdated Show resolved Hide resolved
adam/learner/template_learner.py Outdated Show resolved Hide resolved
adam/situation/templates/phase1_templates.py Outdated Show resolved Hide resolved
tests/learner/subset_verb_learner_test.py Outdated Show resolved Hide resolved
@lichtefeld lichtefeld merged commit 5a3684d into master Aug 13, 2020
@lichtefeld lichtefeld deleted the learn-imprecise-description branch August 13, 2020 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants