Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding EMCF solver #10

Merged
merged 16 commits into from
May 19, 2024
Merged

Adding EMCF solver #10

merged 16 commits into from
May 19, 2024

Conversation

piyushrpt
Copy link
Member

@piyushrpt piyushrpt commented Apr 23, 2024

  • Unwrapping in time first and then in space
  • Support for computing residues and flood filling using gradients
  • Support for including models when computing residues
  • Example usage can be found in tests/workflows/test_emcf.py

@piyushrpt piyushrpt marked this pull request as ready for review April 24, 2024 23:22
@mattcalef mattcalef self-assigned this Apr 25, 2024
Copy link

@mattcalef mattcalef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. I've added a few non-blocking issues, which we can tackle later.

src/spurt/workflows/emcf/_solver.py Outdated Show resolved Hide resolved
src/spurt/workflows/emcf/_solver.py Show resolved Hide resolved
src/spurt/workflows/emcf/_settings.py Show resolved Hide resolved
@piyushrpt
Copy link
Member Author

I will leave this branch till @gmgunter gets a chance to take a better look. No rush. The feature branch should be fully functional.

Copy link
Member

@gmgunter gmgunter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your patience! I'm starting to catch back up now

src/spurt/workflows/emcf/_settings.py Show resolved Hide resolved
src/spurt/workflows/emcf/_settings.py Show resolved Hide resolved
src/spurt/workflows/emcf/_settings.py Show resolved Hide resolved
src/spurt/workflows/emcf/_settings.py Show resolved Hide resolved
src/spurt/workflows/emcf/_settings.py Show resolved Hide resolved
src/spurt/workflows/emcf/_solver.py Show resolved Hide resolved
src/spurt/workflows/__init__.py Show resolved Hide resolved
src/spurt/workflows/emcf/_solver.py Show resolved Hide resolved
src/spurt/links/_interface.py Show resolved Hide resolved
src/spurt/mcf/_interface.py Show resolved Hide resolved
@piyushrpt
Copy link
Member Author

I think the comments here have come in a little too late to address them satisfactorily and not impact the two other PRs that are queued up. I can included them in the last of the PRs that are stringed together. Does that work?

@gmgunter
Copy link
Member

gmgunter commented May 9, 2024

Does that work?

Yeah, that's totally fine with me. I'll continue adding comments as I read through the changes, but they can be addressed in subsequent PRs. I'll approve each of the backlog PRs once I'm finished reviewing it, even if there are remaining comments, until I'm caught back up with you.

Copy link
Member

@gmgunter gmgunter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM, let's go ahead and merge this one. I appreciate it if you could address the comments below in a subsequent PR (or respond to them if they're off-base).

src/spurt/mcf/_ortools.py Show resolved Hide resolved
src/spurt/mcf/_ortools.py Show resolved Hide resolved
src/spurt/mcf/_ortools.py Show resolved Hide resolved
src/spurt/mcf/utils.py Show resolved Hide resolved
test/mcf/test_ortools_mcf.py Show resolved Hide resolved
piyushrpt added a commit to piyushrpt/spurt that referenced this pull request May 18, 2024
@piyushrpt piyushrpt merged commit ea9d38f into isce-framework:main May 19, 2024
1 check passed
@piyushrpt piyushrpt deleted the feat/emcf branch May 19, 2024 00:15
piyushrpt added a commit to piyushrpt/spurt that referenced this pull request May 20, 2024
piyushrpt added a commit to piyushrpt/spurt that referenced this pull request Jun 17, 2024
piyushrpt added a commit to piyushrpt/spurt that referenced this pull request Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants